Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/config: walk the graph and merge configuration #98

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

seilagamo
Copy link
Collaborator

This PR adds the functionality to walk the graph representing the configuration and resolve the final configuration by merging the included configuration files every time a node is visited.

@seilagamo seilagamo requested a review from jroimartin February 3, 2025 08:33
internal/config/testdata/include/common.yaml Outdated Show resolved Hide resolved
internal/config/testdata/include/common_a.yaml Outdated Show resolved Hide resolved
internal/config/testdata/include/no_includes.yaml Outdated Show resolved Hide resolved
internal/config/dag/dag.go Outdated Show resolved Hide resolved
internal/config/configgraph.go Outdated Show resolved Hide resolved
internal/config/configgraph_test.go Outdated Show resolved Hide resolved
@seilagamo seilagamo requested a review from jroimartin February 12, 2025 10:24
Copy link
Contributor

@jroimartin jroimartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I added a couple of minor comments. Clean up commit history.

internal/config/dag/dag.go Outdated Show resolved Hide resolved
internal/config/dag/dag.go Outdated Show resolved Hide resolved
@seilagamo seilagamo force-pushed the walk-graph-and-merge-configuration branch from 7ef5f0c to cda2cf1 Compare February 12, 2025 15:10
Copy link
Contributor

@jroimartin jroimartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seilagamo seilagamo merged commit b3f26c5 into main Feb 12, 2025
6 checks passed
@seilagamo seilagamo deleted the walk-graph-and-merge-configuration branch February 12, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants